Hello

I have a bug with smileys on my installation, and begin to think I have a problem with URL or URL rewriting.

You can check my forum here: http://supra-mk3.club

Smiley problem

When the smileys

:D :) etc..

are posted, the posted message won't point to the good URL, but will in preview:

http://supra-mk3.club/index.php?u=/sites/default/assets/img/smileys/bigsmile.gif

instead of

http://supra-mk3.club/sites/default/assets/img/smileys/bigsmile.gif

I may have broke something, because for older posts it's working:

URLs

Also, for cleanURL, when I've previously talked here with @nguoianphu , he answered:

Your word système becomes syst-amp-egrave-me. I afraid that you have to edit his file for your French language.

codoforum\sys\CODOF\Filter.php

I don't know why it doesn't work althought the Filter.php has this:

'è' => 'e', 'é' => 'e', 'ê' => 'e', 'ë' => 'e'

You may ask @adesh1414127033 for help. I had to replace the Filter.php with another one for my Vietnamese language.

Here is my .htaccess:

<IfModule mod_rewrite.c>
  Options +FollowSymlinks
  Options +Indexes
  RewriteEngine on

  # if your app is in a subfolder
  #RewriteBase /my_app/ 

  # test string is a valid files
  RewriteCond %{SCRIPT_FILENAME} !-f
  # test string is a valid directory
  RewriteCond %{SCRIPT_FILENAME} !-d

  RewriteRule ^(.*)$   index.php?u=/$1    [NC,L,QSA]
  # with QSA flag (query string append),
  # forces the rewrite engine to append a query string part of the
  # substitution string to the existing string, instead of replacing it.
</IfModule>

AddType text/css .less
AddType image/svg+xml svg svgz
AddEncoding gzip svgz

<IfModule mod_deflate.c>
  <FilesMatch ".(js|css|html|php|txt)$">
    SetOutputFilter DEFLATE
  </FilesMatch>
</IfModule>

Here are my modifications in constant.php:

define('CODO_DEBUG', 0);
define('DISPLAY_ERRORS', 'ON');
define('MODE', 'PRODUCTION'); //Can be DEVELOPMENT or PRODUCTION

define('SEF', 1); //Search engine freindly urls , 1=> enable , 0=> disable
define('LOCALE', 'fr_FR');

Am I doing something wrong?

Please help,

Reynald

Hi,

The absolute urls are not getting converted to relative urls.

Did you change anything in sys/Ext/Html.php ?

Hi,

Did you change anything in sys/Ext/Html.php ?

No, nothing. Just to be sure, Diff confirms it

If I try a new post with a smiley, here is the smiley adress in preview:

http://supra-mk3.club/sites/default/assets/img/smileys/smile.gif

and here once posted:

http://supra-mk3.club/index.php?u=/sites/default/assets/img/smileys/smile.gif

@RolluS

Can you make this trick?

codoforum\sites\default\constants.php

Line 75 change to

    if (!SEF) {
        define('RURI', $ruri . 'index.php?u=/');
        define('NRURI', RURI);            
    } else {
        define('RURI', $ruri);
        // define('NRURI', $ruri . 'index.php?u=/');
        define('NRURI', $ruri);
    }

@nguoianphu

That's working! many thanks.

Smiley problem:

Solved (or worked around thanks to @nguoianphu):

• in sites/default/constants.php:

  75 if (!SEF) {
  76        define('RURI', $ruri . 'index.php?u=/');
  77        define('NRURI', RURI);            
  78 } else {
  79        define('RURI', $ruri);
  80        define('NRURI', $ruri); // define('NRURI', $ruri . 'index.php?u=/');
  81 }
  

URLs

Still not solved, and maybe breaking SEO and sitemap generator

Workaround would be to edit all my titles, but I would prefer it to work because I don't want to edit my users topic eventually..

URLs

OK,
I've opened the trunk and found a workaround:

• repair URL_Safe:

  • in sys/CODOF/Filter.php:

    26 static function URL_safe($str, $options = array()) {
    ...
    29     $str = mb_convert_encoding((string) html_entity_decode($str), 'UTF-8', mb_list_encodings()); //$str = mb_convert_encoding((string) $str, 'UTF-8', mb_list_encodings());
    

    Note: line 29: I think it's a bug because obviously if the topic name is encoded before entering the function, there is no symbol to convert.

• in sys/CODOF/Topic.php:

  625 public function gen_topic_arr_all_topics($topics, $search = false) {
  ...
  740                "safe_title" => \CODOF\Filter::URL_safe($topic['title']), //"safe_title" => \CODOF\Filter::URL_safe(html_entity_decode($topic['title'])),
  

  Note: as url is decoded inside URL_safe{}no need to convert here.

• in sites/default/themes/default/templates/forum/topic.tpl:

  09 {block name=body}
  10
  11    {assign "safe_title" html_entity_decode($title)|URL_safe}
  

  I'd prefer directly the function to be modified, but can't understand how that work here (that's already a big thing I achieved to modify CODOF/php files).

• some customisation:

  • add ° like in N°1 (=#1 in French) or °C in sys/CODOF/Filter.php:

    26 static function URL_safe($str, $options = array()) {
    ...
    43    $char_map = array(
    ...
    55    // Latin symbols
    56        '©' => '(c)',
    57        '°' => 'o-', //added
    

  • removed gg at the start of the url in sys/CODOF/Topic.php:

    625 public function gen_topic_arr_all_topics($topics, $search = false) {
    ...
    653         "safe_title" => \CODOF\Filter::URL_safe($topic['title']),  // "safe_title" => "gg''.\CODOF\Filter::URL_safe($topic['title']),
    

Hopefully @adesh1414127033, @avinash, all this could be added in the next release.

Hi,

Awesome work @RolluS and @nguoianphu !

We will make any required changes.

@adesh1414127033 @admin
Will it be inside the comming january update?