General discussion
The links from the Notifications section (the bell in the header) do not scroll exactly to the post

I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page.


there is a difference in the path, here is the path from the home page (from red notification box):
http://www.domain.eu/index.php?u=/topic/topic_number/topic_name/post...


and here is the path from the Notifications section (bell in the header)
http://www.domain.eu/index.php?u=/topic/topic_number/post...


topic_name is missing, when I added the missing topic_name there, the link worked nicely


I found the definition of these links in the file "app.js"


if (data.tid) {
//this is <v.3.7 notification so link needs to be built manually
link = 'topic/' + data.tid + '/post-' + data.pid +
'&page=from_notify&nid=' + notification.id + '#post-' + data.pid;
unique = parseInt(data.tid);}

but I don't know in which variable the topic name is defined so I can put it in the path


Please advice


Thanks


I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page. there is a difference in the path, here is the path from the home page (from red notification box): http://www.domain.eu/index.php?u=/topic/topic_number/topic_name/post... and here is the path from the Notifications section (bell in the header) http://www.domain.eu/index.php?u=/topic/topic_number/post... topic_name is missing, when I added the missing topic_name there, the link worked nicely I found the definition of these links in the file &quot;app.js&quot; if (data.tid) { //this is &lt;v.3.7 notification so link needs to be built manually link = &#039;topic/&#039; + data.tid + &#039;/post-&#039; + data.pid + &#039;&amp;page=from_notify&amp;nid=&#039; + notification.id + &#039;#post-&#039; + data.pid; unique = parseInt(data.tid);} but I don&#039;t know in which variable the topic name is defined so I can put it in the path Please advice Thanks

Hi


We do not actually send the topic name from the server since that's not required for the scrolling to work.
We will have a look at the issue and if the topic name is required we will make the required changes.


Thank you for digging through this issue.


Hi We do not actually send the topic name from the server since that&#039;s not required for the scrolling to work. We will have a look at the issue and if the topic name is required we will make the required changes. Thank you for digging through this issue.
Necessity is the mother of all inventions!
edited Feb 21 at 10:44 pm

I also noticed that link "show all" from Notifications section sometimes gives an error and does not work. Please see the error:


60343fb4a1546


Please advice


I also noticed that link &quot;show all&quot; from Notifications section sometimes gives an error and does not work. Please see the error: ![60343fb4a1546](serve/attachment&amp;path=60343fb4a1546) Please advice

Yes, you are right. It's a bug. Thanks for letting us know.
For a fix you can do this:


In file sites/default/assets/js/app.js


Replace on line 1368


        if (window.location.hash) {

with


        if (window.location.hash && window.location.href.match("/user/profile/[0-9]+/edit") != null) {

topic_name is missing, when I added the missing topic_name there, the link worked nicely


We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!


Yes, you are right. It&#039;s a bug. Thanks for letting us know. For a fix you can do this: In file sites/default/assets/js/app.js Replace on line 1368 ```` if (window.location.hash) { ```` with ```` if (window.location.hash &amp;&amp; window.location.href.match(&quot;/user/profile/[0-9]+/edit&quot;) != null) { ```` [quote=&quot;pid:24777, uid:14442&quot;]topic_name is missing, when I added the missing topic_name there, the link worked nicely[/quote] We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!
Necessity is the mother of all inventions!
edited Feb 23 at 7:48 pm

We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!


any news? thanks!


[quote=&quot;pid:24783, uid:1&quot;]We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks![/quote] any news? thanks!

@richard The @admin already posted a solution for that problem:



Yes, you are right. It's a bug. Thanks for letting us know.
For a fix you can do this:


In file sites/default/assets/js/app.js


Replace on line 1368


    if (window.location.hash) {

with


    if (window.location.hash && window.location.href.match("/user/profile/[0-9]+/edit") != null) {

topic_name is missing, when I added the missing topic_name there, the link worked nicely


We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!




Kind regards, Andy smile


@richard The @admin already posted a solution for that problem: ------------------------------------------------------------------------- Yes, you are right. It&#039;s a bug. Thanks for letting us know. For a fix you can do this: In file sites/default/assets/js/app.js Replace on line 1368 if (window.location.hash) { with if (window.location.hash &amp;&amp; window.location.href.match(&quot;/user/profile/[0-9]+/edit&quot;) != null) { topic_name is missing, when I added the missing topic_name there, the link worked nicely We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks! ------------------------------------------------------------------------- Kind regards, Andy :)

already posted a solution for that problem:


your fix solves this issue


I also noticed that link "show all" from Notifications section sometimes gives an error and does not work. Please see the error:


but not this one


I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page.


[quote=&quot;pid:24805, uid:8261&quot;]already posted a solution for that problem:[/quote] your fix solves this issue [quote=&quot;pid:24782, uid:14442&quot;]I also noticed that link &quot;show all&quot; from Notifications section sometimes gives an error and does not work. Please see the error:[/quote] but not this one [quote=&quot;pid:24777, uid:14442&quot;]I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page.[/quote]

@admin would you be so kind and check back @richard Notification issues please.

For me the Notifications "Show all" link does not work at all, nothing happens if I click it.


Kind regards, Andy smile


@admin would you be so kind and check back @richard Notification issues please. For me the Notifications &quot;**Show all**&quot; link does not work at all, nothing happens if I click it. **Kind regards**, Andy :)
edited Mar 21 at 12:50 pm

Hi,


To fix the topic navigation from notification bell list, you can replace line 505 in routes.php


$forum = new \Controller\forum();

with


$page = ($tname != "" && $page == 1) ? $tname : $page;
$forum = new \Controller\forum();
`

For me the Notifications "Show all" link does not work at all, nothing happens if I click it.


Did you try this below fix?
https://codologic.com/forum/index.php?u=/topic/13022/the-links-from-the-notifications-section-the-bell-in-the-header-do-not-scroll-exactly-to-the-post/1#post-24783


Hi, To fix the topic navigation from notification bell list, you can replace line 505 in routes.php ``` $forum = new \Controller\forum(); ``` with ``` $page = ($tname != &quot;&quot; &amp;&amp; $page == 1) ? $tname : $page; $forum = new \Controller\forum(); ```` [quote=&quot;pid:24807, uid:8261&quot;]For me the Notifications &quot;Show all&quot; link does not work at all, nothing happens if I click it.[/quote] Did you try this below fix? https://codologic.com/forum/index.php?u=/topic/13022/the-links-from-the-notifications-section-the-bell-in-the-header-do-not-scroll-exactly-to-the-post/1#post-24783
Necessity is the mother of all inventions!

@admin

Yes thx man - I fixed the file sites/default/assets/js/app.js some days ago, but for some reasons I did not save and reupload it after the editing in Sublime lol lol lol.


Now all is working well thank you smile


@admin Yes thx man - I fixed the file **sites/default/assets/js/app.js** some days ago, but for some reasons I did not save and reupload it after the editing in Sublime lol lol lol. Now all is working well thank you :)

$page = ($tname != "" && $page == 1) ? $tname : $page;


It does not work, because it started causing issues with adding posts to the topic, the topics are looking like locked


[quote=&quot;pid:24808, uid:1&quot;]$page = ($tname != &quot;&quot; &amp;&amp; $page == 1) ? $tname : $page;[/quote] It does not work, because it started causing issues with adding posts to the topic, the topics are looking like locked

@richard if You need a answer from our @admin it is always best to "mention" him otherwise he might miss your question.

Kind regards, Andy smile


@richard if You need a answer from our @admin it is always best to &quot;mention&quot; him otherwise he might miss your question. Kind regards, Andy ;)
edited Mar 29 at 10:40 am

Hi,


Sorry for the late reply. Thanks @WebCrew .

To fix that weird locking issue, please change this, same place, replace


    dispatch_get('/topic/{tid}[/{tname}[/{page}]]', function (int $tid, $tname = "", $page = 1) {

with


    dispatch_get('/topic/{tid}[/{tname}[/{page}]]', function (int $tid, $tname = "", $page = -1) {
Hi, Sorry for the late reply. Thanks @WebCrew . To fix that weird locking issue, please change this, same place, replace ``` dispatch_get(&#039;/topic/{tid}[/{tname}[/{page}]]&#039;, function (int $tid, $tname = &quot;&quot;, $page = 1) { ``` with ``` dispatch_get(&#039;/topic/{tid}[/{tname}[/{page}]]&#039;, function (int $tid, $tname = &quot;&quot;, $page = -1) { ```
Necessity is the mother of all inventions!
113
15
4
live preview
enter atleast 10 characters
WARNING: You mentioned %MENTIONS%, but they cannot see this message and will not be notified
Saving...
Saved
With selected deselect posts show selected posts
All posts under this topic will be deleted ?
Pending draft ... Click to resume editing
Discard draft