General discussion
The links from the Notifications section (the bell in the header) do not scroll exactly to the post

I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page.


there is a difference in the path, here is the path from the home page (from red notification box):
http://www.domain.eu/index.php?u=/topic/topic_number/topic_name/post...


and here is the path from the Notifications section (bell in the header)
http://www.domain.eu/index.php?u=/topic/topic_number/post...


topic_name is missing, when I added the missing topic_name there, the link worked nicely


I found the definition of these links in the file "app.js"


if (data.tid) {
//this is <v.3.7 notification so link needs to be built manually
link = 'topic/' + data.tid + '/post-' + data.pid +
'&page=from_notify&nid=' + notification.id + '#post-' + data.pid;
unique = parseInt(data.tid);}

but I don't know in which variable the topic name is defined so I can put it in the path


Please advice


Thanks


I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page. there is a difference in the path, here is the path from the home page (from red notification box): http://www.domain.eu/index.php?u=/topic/topic_number/topic_name/post... and here is the path from the Notifications section (bell in the header) http://www.domain.eu/index.php?u=/topic/topic_number/post... topic_name is missing, when I added the missing topic_name there, the link worked nicely I found the definition of these links in the file &quot;app.js&quot; if (data.tid) { //this is &lt;v.3.7 notification so link needs to be built manually link = &#039;topic/&#039; + data.tid + &#039;/post-&#039; + data.pid + &#039;&amp;page=from_notify&amp;nid=&#039; + notification.id + &#039;#post-&#039; + data.pid; unique = parseInt(data.tid);} but I don&#039;t know in which variable the topic name is defined so I can put it in the path Please advice Thanks

Hi


We do not actually send the topic name from the server since that's not required for the scrolling to work.
We will have a look at the issue and if the topic name is required we will make the required changes.


Thank you for digging through this issue.


Hi We do not actually send the topic name from the server since that&#039;s not required for the scrolling to work. We will have a look at the issue and if the topic name is required we will make the required changes. Thank you for digging through this issue.
Necessity is the mother of all inventions!
edited Feb 21 at 10:44 pm

I also noticed that link "show all" from Notifications section sometimes gives an error and does not work. Please see the error:


60343fb4a1546


Please advice


I also noticed that link &quot;show all&quot; from Notifications section sometimes gives an error and does not work. Please see the error: ![60343fb4a1546](serve/attachment&amp;path=60343fb4a1546) Please advice

Yes, you are right. It's a bug. Thanks for letting us know.
For a fix you can do this:


In file sites/default/assets/js/app.js


Replace on line 1368


        if (window.location.hash) {

with


        if (window.location.hash && window.location.href.match("/user/profile/[0-9]+/edit") != null) {

topic_name is missing, when I added the missing topic_name there, the link worked nicely


We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!


Yes, you are right. It&#039;s a bug. Thanks for letting us know. For a fix you can do this: In file sites/default/assets/js/app.js Replace on line 1368 ```` if (window.location.hash) { ```` with ```` if (window.location.hash &amp;&amp; window.location.href.match(&quot;/user/profile/[0-9]+/edit&quot;) != null) { ```` [quote=&quot;pid:24777, uid:14442&quot;]topic_name is missing, when I added the missing topic_name there, the link worked nicely[/quote] We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!
Necessity is the mother of all inventions!
edited Feb 23 at 7:48 pm
36
5
2
live preview
enter atleast 10 characters
WARNING: You mentioned %MENTIONS%, but they cannot see this message and will not be notified
Saving...
Saved
With selected deselect posts show selected posts
All posts under this topic will be deleted ?
Pending draft ... Click to resume editing
Discard draft