I noticed when there are more pages in the topic, the links from the Notifications section (bell in the header) do not scroll exactly to the post, as is the case with the red notification boxes on the front page.

there is a difference in the path, here is the path from the home page (from red notification box):
http://www.domain.eu/index.php?u=/topic/topic_number/topic_name/post...

and here is the path from the Notifications section (bell in the header)
http://www.domain.eu/index.php?u=/topic/topic_number/post...

topic_name is missing, when I added the missing topic_name there, the link worked nicely

I found the definition of these links in the file "app.js"

if (data.tid) {
//this is <v.3.7 notification so link needs to be built manually
    link = 'topic/' + data.tid + '/post-' + data.pid +
'&page=from_notify&nid=' + notification.id + '#post-' + data.pid;
    unique = parseInt(data.tid);}

but I don't know in which variable the topic name is defined so I can put it in the path

Please advice

Thanks

Hi

We do not actually send the topic name from the server since that's not required for the scrolling to work.
We will have a look at the issue and if the topic name is required we will make the required changes.

Thank you for digging through this issue.

Thanks, I will be waiting...

I also noticed that link "show all" from Notifications section sometimes gives an error and does not work. Please see the error:

Please advice

Yes, you are right. It's a bug. Thanks for letting us know.
For a fix you can do this:

In file sites/default/assets/js/app.js

Replace on line 1368

        if (window.location.hash) {

with

        if (window.location.hash && window.location.href.match("/user/profile/[0-9]+/edit") != null) {

We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!

Thank you very much!

Thanks for the links

any news? thanks!

@richard The @admin already posted a solution for that problem:

Yes, you are right. It's a bug. Thanks for letting us know.
For a fix you can do this:

In file sites/default/assets/js/app.js

Replace on line 1368

    if (window.location.hash) {

with

    if (window.location.hash && window.location.href.match("/user/profile/[0-9]+/edit") != null) {

topic_name is missing, when I added the missing topic_name there, the link worked nicely

We checked why this is happening. Apparently when we migrated our router the topic name which was supposed to be optional has become a mandatory parameter in the path. This is a bug, we will fix it. Again, thanks!

Kind regards, Andy

your fix solves this issue

but not this one

@admin would you be so kind and check back @richard Notification issues please.

For me the Notifications "Show all" link does not work at all, nothing happens if I click it.

Kind regards, Andy

Hi,

To fix the topic navigation from notification bell list, you can replace line 505 in routes.php

$forum = new \Controller\forum();

with

$page = ($tname != "" && $page == 1) ? $tname : $page;
$forum = new \Controller\forum();
`

Did you try this below fix?
https://codologic.com/forum/index.php?u=/topic/13022/the-links-from-the-notifications-section-the-bell-in-the-header-do-not-scroll-exactly-to-the-post/1#post-24783

@admin

Yes thx man - I fixed the file sites/default/assets/js/app.js some days ago, but for some reasons I did not save and reupload it after the editing in Sublime lol lol lol.

Now all is working well thank you

It does not work, because it started causing issues with adding posts to the topic, the topics are looking like locked

@richard if You need a answer from our @admin it is always best to "mention" him otherwise he might miss your question.

Kind regards, Andy

Hi,

Sorry for the late reply. Thanks @WebCrew .

To fix that weird locking issue, please change this, same place, replace

    dispatch_get('/topic/{tid}[/{tname}[/{page}]]', function (int $tid, $tname = "", $page = 1) {

with

    dispatch_get('/topic/{tid}[/{tname}[/{page}]]', function (int $tid, $tname = "", $page = -1) {